Improve ASSERT_IS_VALID_CHUNK macro #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenklemm
force-pushed
the
valid_chunk_macro
branch
from
a5308f0
to
dad6c56
Compare
akuzm
approved these changes
Jan 2, 2023
fabriziomello
approved these changes
Jan 2, 2023
svenklemm
force-pushed
the
valid_chunk_macro
branch
2 times, most recently
from
1a9feae
to
bd34d43
Compare
Codecov Report
@@ Coverage Diff @@
## main #5135 +/- ##
==========================================
- Coverage 89.47% 89.44% -0.03%
==========================================
Files 227 227
Lines 51615 51614 -1
==========================================
- Hits 46181 46165 -16
- Misses 5434 5449 +15
Continue to review full report at Codecov.
|
Currently when ASSERT_IS_VALID_CHUNK fails it is impossible to tell which of the conditions fails without opening the coredump in debugger as all the conditions are ANDed in a single Assert. This patch splits the conditions into individual Asserts so you can immediately see from stacktrace which condition failed.
svenklemm
force-pushed
the
valid_chunk_macro
branch
from
bd34d43
to
5b73dfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when ASSERT_IS_VALID_CHUNK fails it is impossible to tell which of the conditions fails without opening the coredump in debugger as all the conditions are ANDed in a single Assert. This patch splits the conditions into individual Asserts so you can immediately see from stacktrace which condition failed.